Remove Fortran parser special-case for C declarations and generalize invalid-syntax handling - #36
Merged
saidctb merged 2 commits intoMay 27, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
_FOREIGN_C_DECLARATIONand_FOREIGN_C_ALIAS_DECLARATIONregexes and the_raise_if_foreign_c_syntax_linehelper, removing the C-specific detection logic._helper_validate_file_scope_unparsed_linesto use a generic invalid-syntax diagnostic and added a clarifying docstring about the language-agnostic guard._raise_if_foreign_c_syntax_linecheck from specification visitors and derived-type parsing helpers so non-Fortran lines are handled by_raise_invalid_fortran_syntax_lineinstead.tests/parser/test_error_handling.py,tests/parser/test_cli.py, andtests/parser/c/test_c_functions.pyto accept the generic invalid-syntax codes/messages.Testing
pytest tests/parserwhich includes the modified tests, and all tests in that subset passed.tests/parser/test_error_handling.py,tests/parser/test_cli.py, andtests/parser/c/test_c_functions.pyand they succeeded with the new generic error behavior.Codex Task